Merged
Conversation
Omit the `text` parameter from Share.share() on iOS where UIActivityViewController treats it as a second shareable item. Android still receives it as EXTRA_TEXT for email body pre-fill. Dismiss the save progress dialog as soon as the hex is ready on all platforms, before entering platform-specific save/share logic. Previously the Download path on iOS left SaveStep.SaveProgress active while the share sheet was open. Nothing then dismissed it if you cancelled.
|
Preview build will be at |
microbit-grace
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omit the
textparameter from Share.share() on iOS where UIActivityViewController treats it as a second shareable item. Android still receives it as EXTRA_TEXT for email body pre-fill. Previously you got the intended file and a file called "text".Dismiss the save progress dialog as soon as the hex is ready on all platforms, before entering platform-specific save/share logic. Previously the Download path on iOS left SaveStep.SaveProgress active while the share sheet was open. Nothing then dismissed it if you cancelled.