Partial flashing #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Substantially the same as in v2. Needs significant refactoring and conversion to TypeScript, but I think it's in a working state and ought to have all the same bugs :) I've somewhat gutted my top-level connection class as it'll be easier to reimplement serial and connection states on top of this.
I think this is enough to merge with some testing, though the code still needs a lot of work.
| export const log = console.log; | ||
|
|
||
| // How was this defined before? Bug? | ||
| export const timeoutMessage = "timeout"; |
Collaborator
Author
There was a problem hiding this comment.
I think this might be the source of the "undefined" case in the error handler, as it was just missing in v2 PartialFlashingUtils. Leaving for a second pass through this though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step PR that aims to get it in a working state.
I've aligned semantics of connect / disconnect with the v2 editor (though I'd like to change them).
The key missing thing is the event reporting via document custom events. The code is similar enough to go through in one pass and reinstate them. I've kept all of the console logging for ease of comparison with the v2 editor, though we'll want to abstract it a bit when we want to get to the point of a reusable library.
Some other minor tweaks based on alignment with v2 also included.
The error-handling UI is pretty much untested, my assumption is that we'll replace it with something bespoke for WebUSB.