Centralised logging. #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparatory work for Sentry crash and GA integration (neither enabled for now, both optional). Holding off configuring this until we have a CircleCI build. I've not reinstated any of the WebUSB events - we need to carefully consider the adapter layer the v2 code has. The events added to project-actions.ts are very simple. Need to consider whether to align them. We should distinguish more cases for sure but this is enough to be helpful as context for Sentry in initial testing.
microbit-matt-hillsdon
force-pushed
the
logging
branch
from
279103e to
96dcc76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparatory work for Sentry crash and GA integration (neither enabled
for now, both optional).
Holding off configuring this until we have a CircleCI build.
I've not reinstated any of the WebUSB events - we need to carefully
consider the adapter layer the v2 code has.
The events added to project-actions.ts are very simple. Need to consider
whether to align them. We should distinguish more cases for sure but
this is enough to be helpful as context for Sentry in initial testing.
First step for #16