Review and test file system #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strip out the file size stuff for now. If we want it we want it to be a different event. #21
I think it's worth dealing with these now, even if the UX for the uploads etc isn't what we'd like ultimately.
It'd apply to main.py too if we didn't change the project identity.
I'd like to avoid it exposing the MicroPythonFs. For now it's only used in tests, where it's useful.
|
Preview build will be at |
Collaborator
Author
|
This is in pretty good shape but I think it's worth addressing most of the comments above before merge. |
Needs checking in Safari.
It's in the wrong place, but it's a start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #21