Convert partial flashing code to TypeScript #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constants situation is a bit unfortunate. CRA via babel doesn't support const enums (which are inlined) so I've not been able to use the type definitions from pxt (or those that are in dapjs). When we extract a separate library that could change so I've tried to keep the access style source compatible.
In pxt this was used to delay reading serial if we were currently flashing. We don't yet have serial working here and v2 doesn't use the field for anything either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add constants for the magic numbers.
No change in behaviour, though I did remove a field that we only write to.