fix: exit with clear error when --waitFor value is not a valid number#271
Merged
lbroudoux merged 1 commit intomicrocks:masterfrom May 4, 2026
Conversation
Signed-off-by: puneeth_aditya_5656 <myakampuneeth@gmail.com>
lbroudoux
approved these changes
May 4, 2026
Member
lbroudoux
left a comment
There was a problem hiding this comment.
Looks legit. Thank you very much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
passing an invalid number to
--waitFor(e.g.--waitFor abcsec) would silently set the timeout to 0ms. the suffix check passed because the unit was correct, butstrconv.ParseIntreturned 0 on the unparseable prefix and the error was discarded with_. the test then fired with a zero timeout and always failed, with no indication of what went wrong.this also affects the invalid-suffix path: the old code printed a warning but did not exit, so the command continued with whatever value
waitForMillisecondshappened to have.both cases now exit with a clear message pointing at the bad value.
tested manually: