fix: continue importing remaining artifacts on failure#394
Open
A-d-i-t-y wants to merge 1 commit into
Open
Conversation
Previously, the import command would exit immediately on the first failed artifact, leaving remaining files unprocessed. Now all artifacts are attempted and a non-zero exit code is returned only if any import failed. Closes microcks#393 Signed-off-by: Aditya <aaaditya1909@gmail.com>
Author
|
Hi @Harsh4902 @Caesarsage, I have raised this PR to fix the early exit bug in the import command when importing multiple artifacts as discussed in issue #393. This is a minimal change — replaced os.Exit(1) with error collection so all artifacts are attempted before exiting. Would love your feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix early exit bug in import command when importing multiple artifacts.
Problem
When running:
microcks import "file1.yaml,file2.yaml,file3.yaml"
If file2.yaml fails, the command immediately exits and file3.yaml
is never imported. User has no visibility into which files succeeded.
Fix
Example output after fix
Failed to import 'file2.yaml': connection refused
Microcks has discovered 'file1.yaml'
Microcks has discovered 'file3.yaml'
Files changed
Closes #393