update the automatic issue creation logic#342
Merged
yada merged 4 commits intomicrocks:masterfrom Feb 17, 2025
Merged
Conversation
Signed-off-by: Rupam-It <mannarupam3@gmail.com>
Signed-off-by: Rupam-It <mannarupam3@gmail.com>
Signed-off-by: Rupam-It <mannarupam3@gmail.com>
Signed-off-by: Rupam-It <mannarupam3@gmail.com>
vickybesra
pushed a commit
to vickybesra/microcks.io
that referenced
this pull request
Feb 23, 2025
* ensure that lychee must create an issue Signed-off-by: Rupam-It <mannarupam3@gmail.com> * improve the logic for automatic issue creation Signed-off-by: Rupam-It <mannarupam3@gmail.com> * update in automatic issue generation Signed-off-by: Rupam-It <mannarupam3@gmail.com> * update in automatic issue generation Signed-off-by: Rupam-It <mannarupam3@gmail.com> --------- Signed-off-by: Rupam-It <mannarupam3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
fix #341
Case 1: No broken links found
Lychee runs and finds no issues.
Exit code = 0, meaning success.
No issue is created. ✅
Case 2: Broken links found
Lychee runs successfully and detects broken links.
Exit code = 1, indicating broken links.
An issue is created to notify developers. ✅
Case 3: Lychee itself fails
Lychee crashes due to an internal error.
Exit code = 2, 127, etc. indicating failure.
No issue is created because we can’t trust the results. ❌