Skip to content

Really fixes #159 - make types unique #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronpk merged 1 commit into from
Mar 26, 2018
Merged

Really fixes #159 - make types unique #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Mf2/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,7 +1166,8 @@ public function parseH(\DOMElement $e, $is_backcompat = false, $has_nested_mf =
}
}

// Make sure things are in alphabetical order
// Make sure things are unique and in alphabetical order
$mfTypes = array_unique($mfTypes);
sort($mfTypes);

// Phew. Return the final result.
Expand Down
10 changes: 10 additions & 0 deletions tests/Mf2/ParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,5 +766,15 @@ public function testMfClassRegex() {
$this->assertArrayHasKey('123-url', $output['items'][0]['properties']);
}

/**
* @see https://github.com/microformats/microformats2-parsing/issues/30
*/
public function testUniqueAndAlphabeticalMfClasses() {
$input = '<div class="h-entry h-cite h-entry"></div>';
$output = Mf2\parse($input);

$this->assertEquals(array('h-cite', 'h-entry'), $output['items'][0]['type']);
}

}