Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: this is a localized refactor from eager sync file reads to cached async lazy-loading, with a focused unit test to prevent regressions. Main risk is timing/initialization differences if callers assume immediate availability of the adblock engine or autoconsent script.
Overview
Switches
gotoadblock initialization to lazy-load heavy assets (engine.binandautoconsent.playwright.js) via cached promise helpers (getEngine,getAutoconsentPlaywrightScript) instead ofreadFileSyncat module import.Updates adblock/autoconsent setup to
await/chain these loaders when enabling/disabling blocking and when injecting/running the autoconsent script, and adds a unit test that asserts requiringadblock.jsperforms zero targeted synchronous reads.Written by Cursor Bugbot for commit c8c8bd0. This will update automatically on new commits. Configure here.