Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Medium risk because it changes how recordings are started/stopped (auto-stop in the extension + new timeout handling) and alters default MP4 codec and constraint behavior, which can affect output compatibility and capture reliability.
Overview
Removes the
qualityoption (and related bitrate presets/exports) from@browserless/capture, simplifying capture configuration and docs/tests accordingly.Shifts recording lifetime control into the extension by passing
durationtoSTART_RECORDINGfor an auto-stop timer, startingMediaRecorderwithout a fixed timeslice, and adding a host-side safety timeout while awaiting the websocket recording buffer.Updates defaults by changing the MP4 default codec to
avc1.640028and no longer forcing amaxFrameRateinto inferred/custom video constraints; the benchmark script now takes a rawBITRATEenv var instead ofQUALITYpresets.Written by Cursor Bugbot for commit 6232a41. This will update automatically on new commits. Configure here.