Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the public error code emitted by
evaluationFailedfromEFAILEDEVALtoEINVALEVAL, which can break consumers that match on the old code/string. Logic is otherwise unchanged and covered by updated tests/docs.Overview
Renames the
evaluationFailederror code fromEFAILEDEVALtoEINVALEVALin@browserless/errors, affecting both directly-created errors and errors normalized viaensureError.Updates the package README examples and the AVA test expectations to reflect the new code/message format.
Written by Cursor Bugbot for commit 7ad06c6. This will update automatically on new commits. Configure here.