Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches the isolated-function template and invocation options to plumb a new
responseobject through, which could subtly affect user function argument shaping and runtime behavior.Overview
Adds support for accessing the initial navigation
HTTPResponsefrom browserless functions via a newresponseargument.gotonow returns{ device, response }; the response is serialized inindex.jsand passed into the isolated runtime as_response, andtemplate.jsreconstructs it into a Puppeteer-like API (callable methods) while ensuring_responseisn’t leaked into user opts.Extends the test suite to cover
responseaccess with and withoutpage, correct serialization/reconstruction behavior, and theundefinedcase when no response is returned.Written by Cursor Bugbot for commit b859137. This will update automatically on new commits. Configure here.