fix(screenshot): normalize white detection to sRGB#710
Merged
Conversation
Convert images to sRGB before reading raw pixels so white screenshot detection uses consistent RGB values across inputs with different color profiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert images to sRGB before reading raw pixels so white screenshot detection uses consistent RGB values across inputs with different color profiles.
Note
Medium Risk
Changes the pixel values used for blank/white screenshot detection by forcing sRGB conversion, which could alter white/near-white classification for some inputs with embedded color profiles.
Overview
Normalizes blank screenshot detection by converting input images to sRGB via Sharp’s
pipelineColourspace('srgb')before extracting raw pixels.This makes the “white screenshot” check consistent across images with different color profiles, but may change pass/fail results for some borderline near-white screenshots.
Written by Cursor Bugbot for commit 7bba361. This will update automatically on new commits. Configure here.