fix(lighthouse): ensure teardown runs when withPage throws#757
Merged
Conversation
Wrap the withPage call in try/finally so the teardown callback always executes, preventing browser context leaks on audit failures. Closes #693 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withPagecall intry/finallyso the teardown callback always executes, preventing browser context leaks when lighthouse audits fail (timeouts, navigation errors, etc.)microlink/api— the existingteardown(() => browserless.close(id))registration works correctly once the teardown is guaranteed to runContext
When
withPage()throws, the teardown callback registered by consumers (e.g.browserless.close(id)in microlink/api) was never called because control flow skipped the teardown line. This caused browser contexts to leak on every failed lighthouse audit.Closes #693
Made with Cursor
Note
Low Risk
Low risk control-flow change that ensures
teardownruns even whenbrowserless.withPagethrows, reducing the chance of leaked browser contexts.Overview
Ensures browser resources are always cleaned up by wrapping the
browserless.withPage(...)()call intry/finallyand moving theteardowninvocation into thefinallyblock.This guarantees teardown executes on Lighthouse failures/timeouts instead of being skipped on exceptions.
Reviewed by Cursor Bugbot for commit e653fb9. Bugbot is set up for automated code reviews on this repo. Configure here.