fix(lighthouse): avoid mutating cached preset config#758
Merged
Conversation
Shallow-copy the preset config before merging user settings so the cached import() module object is never modified across calls. Closes #697 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import()module export is never mutated across callsgetConfig()call leaking into subsequent calls using the same presetContext
import()caches module exports. The previous code assignedconfig.settings = { ... }directly on the cached object, so user-provided settings (e.g.skipAudits,output) from one request would persist into the next request using the same preset within the same process.Closes #697
Made with Cursor
Note
Low Risk
Low risk: small, localized change to config construction that avoids mutating imported preset objects; behavior should be identical aside from preventing cross-call settings leakage.
Overview
Fixes
get-configto avoid mutating the imported Lighthouse preset config (which can be cached byimport()). The function now shallow-copies the preset object and merges user-providedsettingsinto a newconfig.settings, preventing options from one call leaking into later calls using the same preset.Reviewed by Cursor Bugbot for commit 1659f40. Bugbot is set up for automated code reviews on this repo. Configure here.