fix(screencast): throw if start() is called without onFrame handler#763
Merged
Conversation
Fail fast with a clear error instead of silently dropping frames when no callback is registered before starting the screencast. Closes #698 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start()is called before registering anonFramecallback, instead of silently dropping framesonFramebeforestart()where missingContext
If
start()was called beforeonFrame(), CDP frames were acknowledged but never delivered to the caller, with no error or warning. This makes the API fail fast with an actionable message.Closes #698
Made with Cursor
Note
Low Risk
Low risk: adds a fail-fast runtime check and adjusts tests; behavior only changes for incorrect caller usage (calling
start()without registeringonFrame).Overview
packages/screencastnow throws a clear error ifstart()is called before anonFramecallback is registered, instead of starting the CDP screencast and silently dropping frames.Tests are updated to always register a no-op
onFramehandler before starting screencast sessions, keeping the listener cleanup assertions intact.Reviewed by Cursor Bugbot for commit ed06bb5. Bugbot is set up for automated code reviews on this repo. Configure here.