Ci recheck#262
Closed
Kikobeats wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shadow DOM detector upgrades a fetch to prerender on any hyphenated
tag, which over-triggers on sites full of custom elements (e.g. YouTube's
polymer shell: ytd-app, yt-formatted-string). When a caller explicitly
passes
prerender: falseit has opted out of rendering, so the autoupgrade must not override it — otherwise crawler-fetch domains get
prerendered anyway and lose their server-rendered metadata.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Note
Low Risk
Small guard on an existing retry branch; reduces unintended prerendering and aligns with prior explicit-disable behavior.
Overview
Fetch-to-prerender retry after shadow-DOM detection no longer runs when the caller passes
prerender: false, so fetch-only crawls keep server-rendered HTML instead of being forced through the browser.Hyphenated custom-element tags (e.g. YouTube’s
ytd-*shell) can still trigger the detector; explicit opt-out now wins over that auto-upgrade whengetBrowserlessis available.Reviewed by Cursor Bugbot for commit 4a10088. Bugbot is set up for automated code reviews on this repo. Configure here.