modified CliHeadParamTest to cover http headers sent in multiple lines #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymc12
reviewed
Feb 7, 2019
tck/src/main/java/org/eclipse/microprofile/rest/client/tck/ClientHeaderParamTest.java
Show resolved
Hide resolved
andymc12
reviewed
Feb 7, 2019
tck/src/main/java/org/eclipse/microprofile/rest/client/tck/ClientHeaderParamTest.java
Outdated
Show resolved
Hide resolved
andymc12
requested changes
Feb 7, 2019
Contributor
andymc12
left a comment
andymc12
left a comment
There was a problem hiding this comment.
We still need to import Map - and the typo is just a minor comment. Would you mind also removing the commented code in the stub method? I must've left that in there when I was working on the original test - sorry about that. Thanks!
Changed `ClientHeaderParamClient#methodOptionalMethodHeaderNotSentWhenComputeThrowsException` and `ClientHeadersFactoryClient#delete` to return `JsonObject` Signed-off-by: Michal Szynkiewicz <michal.l.szynkiewicz@gmail.com>
michalszynkiewicz
force-pushed
the
headers-in-multiple-lines
branch
from
810a285 to
a4b2eb7
Compare
andymc12
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.