Skip to content

Conversation

@ttelang
Copy link
Contributor

@ttelang ttelang commented Dec 9, 2024

Adding content for chapter08

Chapter 8: MicroProfile Fault Tolerance
Added chapter Introduction
@ttelang ttelang marked this pull request as draft December 9, 2024 17:34
ttelang and others added 6 commits January 24, 2025 08:55
Co-authored-by: Emily Jiang <emijiang6@googlemail.com>
Co-authored-by: Emily Jiang <emijiang6@googlemail.com>
Co-authored-by: Emily Jiang <emijiang6@googlemail.com>
Copy link
Member

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the tutorial! I read through it and noted a few minor corrections.

ttelang and others added 7 commits January 25, 2025 04:46
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
ttelang and others added 2 commits January 25, 2025 04:52
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
updating source code for Fallback example
changes to Timeout example source code
updating code for PaymentService with the fallback example
updating code examples for asynchronous and bulkhead sections
Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This chapter did not mention the configuration update here

Updating about @asynchronous annotation in the table
Updated Fallback example explanation with the call sequence flow.
Added sections about externalizing fault-tolerance using MicroProfile Configuration
@ttelang
Copy link
Contributor Author

ttelang commented Feb 25, 2025

This chapter did not mention the configuration update here

Updated. @Emily-Jiang This PR is now ready to merge as all feedbacks have been incorporated. Please merge this to main branch.

Adding connecting sentences between each code snippets to improve readability.
@ttelang
Copy link
Contributor Author

ttelang commented Feb 25, 2025

This chapter did not mention the configuration update here

Updated this tutorial with content how to apply configuration using MicroProfile Config.

Changing CompletableFuture to CompletionStage
Copy link
Contributor Author

@ttelang ttelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating CompletableFuture to CompletionStage

Updating source code examples
@ttelang
Copy link
Contributor Author

ttelang commented Feb 28, 2025

updated CompletionStage<String> as the return type instead of CompletableFuture<String> to make the method more generic and flexible.

@Emily-Jiang Emily-Jiang merged commit 16b6f7b into microprofile:main Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants