This repository was archived by the owner on Sep 6, 2023. It is now read-only.
Hardware SPI #64
Closed
Hardware SPI #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esp32/machine_hspi.h: Adding HW SPI support
esp32/modmachine.h: Updated with machine_hw_spi_type esp32/machine_hw_spi.c: Added machine_hw_spi_type
dpgeorge
reviewed
Apr 5, 2017
Member
dpgeorge
left a comment
dpgeorge
left a comment
There was a problem hiding this comment.
Apart from the single comment it looks good!
Also, please confirm that all code was your own, or derived from this code base.
esp32/machine_hw_spi.c
Outdated
| // if a port didn't define MSB/LSB constants then provide them | ||
| #ifndef MICROPY_PY_MACHINE_SPI_MSB | ||
| #define MICROPY_PY_MACHINE_SPI_MSB (0) | ||
| #define MICROPY_PY_MACHINE_SPI_LSB (1) |
Member
There was a problem hiding this comment.
These should be moved to esp32/mpconfigport.h; see stmhal/mpconfigport.h for hints.
Contributor
Author
There was a problem hiding this comment.
Got it. Will update tomorrow.
esp32/mpconfigport.h: Moved SPI constants to mpconfigport.h
Contributor
Author
|
Haven't tested the last commit, yet. My ESP32 is at work. |
Contributor
Author
Yes, all mine; I only looked at the ESP-IDF documentation, and ESP-IDF code examples, and the MicroPython source files. There aren't any licensing issues. |
Contributor
Author
|
Okay, tested. Should be good to go. |
Member
|
Thank you! Rebased, squashed and merged in 38c6e55. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With changes as discussed in other PR.
Also, the baudrate worked fine for me, using SPI1 and all native pins.