binascii: Add required argument to <int>.to_bytes(...) call.#203
Closed
ccooper21 wants to merge 1 commit intomicropython:masterfrom
Closed
binascii: Add required argument to <int>.to_bytes(...) call.#203ccooper21 wants to merge 1 commit intomicropython:masterfrom
ccooper21 wants to merge 1 commit intomicropython:masterfrom
Conversation
ccooper21
changed the title
ccooper21
force-pushed
the
binascii-a2b_base64-fix
branch
2 times, most recently
from
418c445 to
ebf07f1
Compare
The <int>.to_bytes(...) function requires two arguments. The first specifies the number of bytes to return, and the second specifies the endianness of those bytes. By definition, Base64 encoding is big endian.
ccooper21
force-pushed
the
binascii-a2b_base64-fix
branch
from
ebf07f1 to
19a5511
Compare
Contributor
|
Merged, thanks. Also added testcase which exposed the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
a2b_base64(...)function in thebinasciimodule was failing due to an invalid call being made to the<int>.to_bytes(...)function. The<int>.to_bytes(...)function requires two arguments. The first specifies the number of bytes to return, and the second specifies the endianness of those bytes. By definition, Base64 encoding is big endian.This change also fixed the test cases for the
base64module.