umqtt.simple: add force_close parameter to disconnect() to ensure soc…#243
Closed
jzafran wants to merge 1 commit intomicropython:masterfrom
Closed
umqtt.simple: add force_close parameter to disconnect() to ensure soc…#243jzafran wants to merge 1 commit intomicropython:masterfrom
jzafran wants to merge 1 commit intomicropython:masterfrom
Conversation
umqtt.simple: add force_close parameter to disconnect() to ensure socket is closed if there's an error sending disconnect message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
force_closeargument toumqtt.simple.MQTTClient.disconnect()that, when set, ensuressocket.close()is called even if there's an error while sending the disconnect message to the MQTT server.The default behavior is the same as before - I'm tempted to change it; I believe it would be a better default, but I don't want to break any backward compatibility.