Skip to content

contextlib: port ExitStack from CPython 3.4#51

Merged
pfalcon merged 4 commits intomicropython:masterfrom
dxxb:dxxb/exitstack
Nov 3, 2015
Merged

contextlib: port ExitStack from CPython 3.4#51
pfalcon merged 4 commits intomicropython:masterfrom
dxxb:dxxb/exitstack

Conversation

@dxxb
Copy link
Copy Markdown
Contributor

@dxxb dxxb commented Oct 31, 2015

See discussion in #49

@dxxb
Copy link
Copy Markdown
Contributor Author

dxxb commented Oct 31, 2015

I am not sure I like the fact I changed instances of of assertIsNone() to assert is None. I'm happy to add assertIsNone() to unittest and get back to this.

@pfalcon
Copy link
Copy Markdown
Contributor

pfalcon commented Oct 31, 2015

I am not sure I like the fact I changed instances of of assertIsNone() to assert is None. I'm happy to add assertIsNone() to unittest and get back to this.

Sure, feel free to, unittest is not size-critical (it's just big mess o'code from my point of view, so I didn't even try to port it, instead was adding method on as-needed basis, other contributed a bunch too).

@dxxb
Copy link
Copy Markdown
Contributor Author

dxxb commented Nov 1, 2015

I'd rather use 'assert x is None' directly but it would result in more line changes when porting tests from CPython. I have created #52 and rebased this PR on it.

@dxxb
Copy link
Copy Markdown
Contributor Author

dxxb commented Nov 1, 2015

Hi @pfalcon, this is ready to be reviewed.

@dxxb
Copy link
Copy Markdown
Contributor Author

dxxb commented Nov 3, 2015

PR updated. Prefixed incompatible test names with underscore.

@pfalcon
Copy link
Copy Markdown
Contributor

pfalcon commented Nov 3, 2015

Merged, thanks.

@dxxb
Copy link
Copy Markdown
Contributor Author

dxxb commented Nov 3, 2015

Apologies for the oversight and thank you.

@dxxb dxxb deleted the dxxb/exitstack branch October 27, 2016 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants