wait_msg() return op as indication if there was a message#528
Closed
meirarmon wants to merge 1 commit intomicropython:masterfrom
Closed
wait_msg() return op as indication if there was a message#528meirarmon wants to merge 1 commit intomicropython:masterfrom
meirarmon wants to merge 1 commit intomicropython:masterfrom
Conversation
Member
|
Thanks for the contribution, this is a nice and simple improvement. Rebased and merged in b50d346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As indicated in this issue: #328, it would be useful if wait_msg() would return a value if a message was received.
A common use case using this library would be:
In the above scenario, if more than one message was published to the topic being subscribed to, it will still get consumed every seconds. If this change is merged, we would be able to do:
And any waiting messages will get consumed immediately.