drivers/sensor/dht: Change the sequence for importing dht_readinto. #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the machine module first, then search in previous places.
|
I'm not sure what this achieves? One thing it does do is make the code bigger with the additional error message 😄 Probably best to just move all |
|
The intention is legacy, such that the 'new' dht.py works with previous versions of the firmwarem, at least for a while. |
|
Oh, I see! Yes that makes sense then. Probably good to add a comment then, why the older imports are there. Also, except for the esp case, the port-specific cases can actually be combined to: dht_readinto = __import__(sys.platform).dht_readinto |
As @dpgeorge suggested. If the import fails, the error message is somewhat cryptic. It says: `AttributeError: no such attribute` But that's anyhow only a transitional state of the driver.
|
Squashed and merged in 0e25b10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the machine module first, then try the port specific places.