Add LED.set() function #70
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyb/pyb.py
Outdated
| self.f.write(b"0") | ||
|
|
||
| def set(self, v): | ||
| self.f.write(b"{}".format(0 if v < 0 else 255 if v > 255 else v)) |
There was a problem hiding this comment.
I find this much clearer to read:
self.f.write(b"{}".format(max(0, min(255, v)))
There was a problem hiding this comment.
Maybe, but it involves 2 function calls. And the original is almost plain English anyway ;-).
There was a problem hiding this comment.
Should I revert it to what I had before?
|
@Ivoah : Sorry, I'm losing track of things ;-). I thought @SpotlightKid's comment was about a file already in a master, not about a pull request. The problem with this patch is that this module is intended to emulate pyboard's "pyb" module. And pyb.LED class of pyboard doesn't have .set() method. |
|
Well, I could always make a pull request to the main pyb module too ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.