all: Rename utarfile->tarfile and urequests->requests. #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I haven't provided a wrapper for utarfile... not sure this is necessary? |
Member
I'd say it's not necessary. Users can easily provide their own |
This is compatible with the CPython module, so should be named tarfile. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
This module implements a subset of the Python requests module, and so it should have the same name. Added a backwards-compatibility wrapper to allow people to continue to use `import urequests`. This lives in micropython/urequests. Changed requests to be a package, so that we can implement extension packages in the future for optional functionality. Added a basic README.md to both. This work was funded through GitHub Sponsors. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends on #540, with four main differences:
__init__.pyto allow extension in the future.requests.Note that the unix port currently gets
urequestsvia mip, so now it will only getrequests. For backwards compatibility, when the submodule is updated we will might want to consider addingrequire("urequests")tounix/variants/manifest.py. All other ports currently geturequestsvia bundle-networking and so will now get both.