all: Enable ruff linter check for undefined-name (F821). #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projectgus
force-pushed
the
bugfix/ruff_enable_f821
branch
2 times, most recently
from
7eedda9 to
bd2df6f
Compare
Looks like copy-pasta from bmi270 driver. There is a soft reset capability documented in the BMM150 datasheet, but it uses different register bits and I don't have a BMM150 at hand to test it. Found by Ruff checking F821. Signed-off-by: Angus Gratton <angus@redyak.com.au>
Driver calls time.sleep_ms() in one place. Found by Ruff checking F821. Signed-off-by: Angus Gratton <angus@redyak.com.au>
Found by Ruff checking F821. Signed-off-by: Angus Gratton <angus@redyak.com.au>
Found by Ruff checking F821. Signed-off-by: Angus Gratton <angus@redyak.com.au>
These were probably intentional missing names, however raising NotImplementedError or KeyError is more explicit than trying to call an unknown function. Signed-off-by: Angus Gratton <angus@redyak.com.au>
This is a change just to make the linter happy, the code probably would have run OK without it. Found by Ruff checking F821. Signed-off-by: Angus Gratton <angus@redyak.com.au>
As-written this code is unreachable (return statement two line above), so this change is really just to make the linter happy. Found by Ruff checking F821. Signed-off-by: Angus Gratton <angus@redyak.com.au>
Also adds some global ignores for manifest files (which have implicit imports) and the multitests (which have the same). Other F821 fixes or accommodations are in the parent commits to this commit. Signed-off-by: Angus Gratton <angus@redyak.com.au>
dpgeorge
force-pushed
the
bugfix/ruff_enable_f821
branch
from
bd2df6f to
5b6fb2b
Compare
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run a linter in your editor or other part of your workflow then checking undefined-name (F821) is excellent for quickly catching typos, missing imports, etc.
This is the sibling PR to micropython/micropython#12197
Changes include:
manifest.pyfiles and the aioblemultitests.This PR does not include the fix from #713, so workflow run will fail until it can be rebased to include it. (:heavy_check_mark: )
This work was funded by GitHub sponsors.