python-ecosys/aiohttp: Fix binary data treatment. #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carglglz
force-pushed
the
aiohttp-fix
branch
2 times, most recently
from
8f246f6 to
de5ec7f
Compare
bixb922
suggested changes
Jan 4, 2024
bixb922
left a comment
bixb922
left a comment
There was a problem hiding this comment.
I'd suggest not to specify "latin-1" as encoding. This parameter is AFAIK ignored for .encode(), and the encoding for JSON has to be UTF-8, which is the default for .encode()
Carglglz
force-pushed
the
aiohttp-fix
branch
2 times, most recently
from
30ff507 to
7cb445f
Compare
dpgeorge
reviewed
Feb 7, 2024
- Fix binary data `Content-type` header and data `Content-Length` calculation. - Fix query length when data is included. - Fix `json` and `text` methods of `ClientResponse` to read `Content-Length` size Signed-off-by: Carlos Gil <carlosgilglez@gmail.com>
Member
|
Thanks for updating, now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #781, #784, #788