tarfile-write: fix TarInfo mode in add() method. Set permissions to 644 instead of 000 (fixes #797) #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubidefeo
changed the title
Contributor
Author
|
set as draft as I investigate further issues with |
Contributor
Author
|
I'll open a new PR with a properly named branch from my fork and better compliance with the contribution guidelines :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes issue #797 which I opened a bit earlier.
I'm not sure how to go about this PR because the suggested change doesn't require a lot of the code linting and other requests from the contributing guidelines, but maybe I'm missing something.
I didn't even clone the repository but did everything in GitHub to avoid VS Code applying weirdness to the file format,
hope it works out.
thanks
ubi