py/obj: Add mp_obj_malloc_with_finaliser helper. #13685
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 16, 2024 15:53
Also matching mp_obj_malloc_var_with_finaliser.
These can be used like the mp_obj_malloc{,_var} macros
for situations where a finaliser is needed.
Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>
Replace usages of m_new_obj_with_finaliser() with separate type setting with the mp_obj_malloc_with_finaliser helper. Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13685 +/- ##
==========================================
- Coverage 98.36% 98.36% -0.01%
==========================================
Files 159 159
Lines 21069 21065 -4
==========================================
- Hits 20724 20720 -4
Misses 345 345 ☔ View full report in Codecov by Sentry. |
|
Code size report: |
Contributor
Author
|
Duplicate of #13682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro & helper pair
mp_obj_malloc&mp_obj_malloc_varis already present for use when creating a new object and setting its base.type immediately.This PR introduces matching
mp_obj_malloc_with_finaliser&mp_obj_malloc_var_with_finaliserhelpers to use in the same way for classes that need a finaliser (ie automatic running of__del__when the object is garbase collected).