tools/metrics.py: Change rp2 board selection to RPI_PICO_W. #15197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15197 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 161 161
Lines 21204 21204
=======================================
Hits 20864 20864
Misses 340 340 ☔ View full report in Codecov by Sentry. |
|
Code size report: |
dpgeorge
force-pushed
the
tools-metrics-change-rp2-to-w
branch
2 times, most recently
from
0e6dd30 to
7d2b702
Compare
This tool is used to compute size differences in the firmware (eg as part of CI), but it doesn't currently check any firmware that has bare-metal lwIP/networking, making it hard to see how firmware size changes when networking related changes are made. So, change the board selection for the rp2 port to RPI_PICO_W. Changes in size to standard RPI_PICO firmware will be very similar to other bare-metal boards like PYBV10. Signed-off-by: Damien George <damien@micropython.org>
dpgeorge
force-pushed
the
tools-metrics-change-rp2-to-w
branch
from
7d2b702 to
0e19286
Compare
Member
Author
|
The correct code-size-diff output won't work until this is merged to master (because it's trying to compare previous |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool is used to compute size differences in the firmware (eg as part of CI), but it doesn't currently check any firmware that has bare-metal lwIP/networking, making it hard to see how firmware size changes when networking related changes are made.
So, change the board selection for the rp2 port to RPI_PICO_W. Changes in size to standard RPI_PICO firmware will be very similar to other bare-metal boards like PYBV10.