tests/extmod/random_extra_float.py: Skip when funcs not available. #17378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17378 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 169 169
Lines 21941 21941
=======================================
Hits 21621 21621
Misses 320 320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This test was factored out from `random_extra.py` back in commit 6572029, and the skip logic copied from that file. But the skip logic needs to test that the `random` and `uniform` functions exist, not `randint`. This commit fixes that skip logic. Signed-off-by: Damien George <damien@micropython.org>
dpgeorge
force-pushed
the
tests-extmod-random-extra-float-proper-skip
branch
from
fba45e9 to
e4d556b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This test was factored out from
random_extra.pyback in commit 6572029, and the skip logic copied from that file. But the skip logic needs to test that therandomanduniformfunctions exist, notrandint.This commit fixes that skip logic.
Testing
Tested on RPI_PICO2_W in RISCV mode, the test now correctly skips.