Wake on ext0 only if supported #17394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meirarmon
force-pushed
the
wake-on-ext0-only-if-supported
branch
from
a238ed8 to
2e08b04
Compare
ports/esp32: esp32.wake_on_touch should only be available on boards
that have SOC_TOUCH_SENSOR_SUPPORTED=y
docs/library/esp32.rst: update docs to reflect that wake_on_touch
is only available for boards that have touch sensor support
Signed-off-by: Meir Armon <meirarmon@gmail.com>
ports/esp32: esp32.wake_on_ext0 should only be available on boards
that have SOC_PM_SUPPORT_EXT0_WAKEUP=y
docs/library/esp32.rst: update docs to reflect that wake_on_ext0
is only available for boards that have support for ext0
Signed-off-by: Meir Armon <meirarmon@gmail.com>
meirarmon
force-pushed
the
wake-on-ext0-only-if-supported
branch
from
efc6181 to
08cf66b
Compare
Member
|
Closing in favour of #17397. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports/esp32: esp32.wake_on_ext0 should only be available on boards
that have SOC_PM_SUPPORT_EXT0_WAKEUP=y
docs/library/esp32.rst: update docs to reflect that wake_on_ext0
is only available for boards that have support for ext0
Summary
Having code wrapped by definitions of whether or not the capability is supported on the
board instead of what board it is, is better practice.
I introduced this so that when using the method wake_on_ext0 on boards that don't
support it, it will be clear that it is not supported, instead of silently failing.
Testing
I tested this on the ESP32C3
Merge this after #17393