asmbase: Fix assertion error with viper code. #17499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of viper code it's possible to reach MP_ASM_PASS_EMIT with a code size of 0 bytes. Update the assertion accordingly. After this change, `mpy-cross -march=debug' on the viper tests creates output that looks plausible to me, though I am not experienced in reading the output. Signed-off-by: Jeff Epler <jepler@gmail.com> Closes: micropython#17467
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17499 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 169 169
Lines 21946 21946
=======================================
Hits 21626 21626
Misses 320 320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dpgeorge
approved these changes
Jun 15, 2025
Member
|
Rebased and merged in 5ff2ae5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the case of viper code it's possible to reach MP_ASM_PASS_EMIT with a code size of 0 bytes. Update the assertion accordingly.
After this change, `mpy-cross -march=debug' on the viper tests creates output that looks plausible to me, though I am not experienced in reading the output.
Closes: #17467
Testing
I locally ran mpy-cross on some viper files.
Trade-offs and Alternatives
As this just changes an assertion it's unlikely to affect real ports.
I briefly considered that the code size could also be forced non-zero but this would add code and doesn't appear to be necessary. Or, that the debug backend emitter could set its own length, but this does not seem to be necessary.