fix: It crashes if enable MICROPY_DEBUG_VERBOSE #5182
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If enable `MICROPY_DEBUG_VERBOSE`, `mp_thread_mutex_lock(&MP_STATE_VM(gil_mutex), 1)` and `mp_thread_mutex_unlock(&MP_STATE_VM(gil_mutex))` were called before `mp_thread_mutex_init(&MP_STATE_VM(gil_mutex))`.
Member
|
IMO this is not the right way to fix the issue, because the GC should not be initialising and acquiring the GIL. I think it should be up to the ports to make sure they don't crash on debug printing. |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 24, 2021
Check background pending before sleep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MICROPY_DEBUG_VERBOSE,mp_thread_mutex_lock(&MP_STATE_VM(gil_mutex), 1)andmp_thread_mutex_unlock(&MP_STATE_VM(gil_mutex))were called beforemp_thread_mutex_init(&MP_STATE_VM(gil_mutex)).