Problem
PR #174 enabled a 5-minute cron schedule on the orchestrator, but the cron runs are immediately skipped because the job-level if: condition does not include schedule as an allowed event name.
if: >-
github.event_name == 'workflow_dispatch' ||
github.event_name == 'push' ||
(github.event_name == 'workflow_run' && ...) ||
(github.event_name == 'pull_request_review' && ...)
The schedule event fires correctly (confirmed in Actions UI at 07:52:45 UTC), but github.event_name == 'schedule' is not in the condition, so the orchestrate job is skipped every time.
Root Cause
Copilot CLI (me) added the cron trigger to the on: block but did not update the if: condition on the job to allow schedule events through. This is the same pattern as adding a trigger without testing it — which we have been burned by multiple times.
Fix
Add github.event_name == 'schedule' to the if: condition on the orchestrate job.
Lesson
When adding a new trigger to on:, always check if the job has an if: condition that gates on event_name. If it does, update it to include the new trigger. This is the second time we have added a trigger without updating the gate (first was quality gate pull_request_review → workflow_dispatch without updating the if:).
Related
Problem
PR #174 enabled a 5-minute cron schedule on the orchestrator, but the cron runs are immediately skipped because the job-level
if:condition does not includescheduleas an allowed event name.The
scheduleevent fires correctly (confirmed in Actions UI at 07:52:45 UTC), butgithub.event_name == 'schedule'is not in the condition, so theorchestratejob is skipped every time.Root Cause
Copilot CLI (me) added the cron trigger to the
on:block but did not update theif:condition on the job to allowscheduleevents through. This is the same pattern as adding a trigger without testing it — which we have been burned by multiple times.Fix
Add
github.event_name == 'schedule'to theif:condition on theorchestratejob.Lesson
When adding a new trigger to
on:, always check if the job has anif:condition that gates onevent_name. If it does, update it to include the new trigger. This is the second time we have added a trigger without updating the gate (first was quality gatepull_request_review→workflow_dispatchwithout updating theif:).Related