Use new variable in Set-VersionInSettingsFile#1044
Merged
mazhelez merged 2 commits intomicrosoft:mainfrom Apr 18, 2024
Merged
Conversation
…anged when reassigning
freddydk
previously approved these changes
Apr 18, 2024
freddydk
approved these changes
Apr 18, 2024
aholstrup1
approved these changes
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use new variable in
Set-VersionInSettingsFileas variable type isn't changed.Issue:
$newValueis of type string by default.The assignment
$newVersion = [System.Version] "$($versionNumbers -join '.')"doesn't change the variable's type and forces string comparison afterwards.Solution: Use new variable.
Fixes #1041