Add trigger 'workflow_call' to workflow 'UpdateGitHubGoSystemFiles' for reusability #2031

OleWunschmann · 2025-11-19T19:52:21Z

❔What, Why & How

What:

This change enables the update workflow to be called by other workflows as a reusable workflow.

Why:

Creating the second (or subsequent) project using one of the app creation workflows results in an incorrect “.AL-Go” directory in the created project.
This creates an even bigger problem for our custom template, as our template contains additional files that are missing from the “.AL-Go” directories of new projects.

As discussed in #1855, there should be an actual solution that requires a revision of the current logic for changing and committing files.
In the short term, however, we want to call the update workflow from a custom job in each app creation workflow.

Related to issue: #1855

✅ Checklist

Add/Update unit tests
Update RELEASENOTES.md
Update documentation

… reusability

Copilot

Pull Request Overview

This PR adds reusable workflow support to the UpdateGitHubGoSystemFiles workflow by adding the workflow_call trigger. This allows other workflows to call this workflow programmatically, which addresses an issue where creating multiple projects results in incorrect .AL-Go directories in newly created projects.

Key changes:

Added workflow_call trigger with duplicate input definitions mirroring workflow_dispatch inputs
Updated the input handling logic to support both workflow_dispatch and workflow_call event types

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
Templates/AppSource App/.github/workflows/UpdateGitHubGoSystemFiles.yaml	Added `workflow_call` trigger and updated event type checking logic to support reusable workflow pattern
Templates/Per Tenant Extension/.github/workflows/UpdateGitHubGoSystemFiles.yaml	Added `workflow_call` trigger and updated event type checking logic to support reusable workflow pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

… reusability

mazhelez · 2025-11-20T17:43:05Z

Hey @OleWunschmann

PR looks good. There has been a recent addition to modify the default inputs for workflows (see #1987). I suppose, this is something that needs adjusting for workflow_call as well.

OleWunschmann · 2025-11-20T18:12:08Z

Hey @OleWunschmann

PR looks good. There has been a recent addition to modify the default inputs for workflows (see #1987). I suppose, this is something that needs adjusting for workflow_call as well.

Thanks for the feedback, @mazhelez.

I looked into this and came to the conclusion that including workflow_call in the default inputs logic could be a problem, because the workflow _Build AL-Go Project also uses this trigger.
I think it would be better to declare the inputs of the workflow_call as required inputs without default values.
Alternativly we could also include workflow_call in the logic but exclude the build workflow.

Also the pr #2033 wants to add the possibility to hide some inputs by removing them.
This is not possible for workflow_call because the calls of the workflow would still need the inputs.

If this pr is something that gets implemented we would need another solution.
A possible solution could be to split the update workflow into two workflows:

New reusable workflow
- Copy of current workflow
- Only workflow_call instead of workflow_dispatch
  - Additional input for original event name
- References to original event name from input instead of event name
Current workflow
- Only workflow_dispatch (as is)
- Only contains calls of reusable workflow with passthru of the inputs

This would allow the new default inputs to be applied to the dispatch workflow without breaking the call workflow.
A problem with this would be that other calls of the reusable workflow would not inherit the default settings.
To work around this we could set the inputs of the reusable workflow as required without default values.

What do you think?

mazhelez · 2025-11-24T21:37:30Z

For one, nice analysis! 💯

Here are my thoughts:

I looked into this and came to the conclusion that including workflow_call in the default inputs logic could be a problem, because the workflow _Build AL-Go Project also uses this trigger. I think it would be better to declare the inputs of the workflow_call as required inputs without default values. Alternativly we could also include workflow_call in the logic but exclude the build workflow.

How about changing the default inputs on workflow_call only if there is a workflow_dispatch trigger as well?

Also the pr #2033 wants to add the possibility to hide some inputs by removing them. This is not possible for workflow_call because the calls of the workflow would still need the inputs.

Hiding inputs makes sense only for the workflow_dispatch trigger. As far as I understood, it's a cosmetic feature: the inputs are hidden in the UI.

If this pr is something that gets implemented we would need another solution. A possible solution could be to split the update workflow into two workflows:

New reusable workflow

Copy of current workflow

Only workflow_call instead of workflow_dispatch

Additional input for original event name

References to original event name from input instead of event name

Current workflow

Only workflow_dispatch (as is)

Only contains calls of reusable workflow with passthru of the inputs

This would allow the new default inputs to be applied to the dispatch workflow without breaking the call workflow. A problem with this would be that other calls of the reusable workflow would not inherit the default settings. To work around this we could set the inputs of the reusable workflow as required without default values.

What do you think?

I do think this could be the right approach long term, but it requires way more investment, testing, etc. "Update AL-Go" is quite an important process and must not break.

mazhelez · 2025-12-03T12:11:53Z

⚠️ Release Notes Update Reminder

Thank you for updating the release notes!

Please ensure that your changes are placed above the new version section (currently ## v8.1) in the RELEASENOTES.md file.

This helps maintain a clear changelog structure where new changes are grouped under the latest unreleased version.

OleWunschmann · 2025-12-03T13:07:39Z

@mazhelez please excuse my late reply. I was out of the office last week.

I looked into this and came to the conclusion that including workflow_call in the default inputs logic could be a problem, because the workflow _Build AL-Go Project also uses this trigger. I think it would be better to declare the inputs of the workflow_call as required inputs without default values. Alternativly we could also include workflow_call in the logic but exclude the build workflow.

How about changing the default inputs on workflow_call only if there is a workflow_dispatch trigger as well?

Good idea, I'll implement it.

Also the pr #2033 wants to add the possibility to hide some inputs by removing them. This is not possible for workflow_call because the calls of the workflow would still need the inputs.

Hiding inputs makes sense only for the workflow_dispatch trigger. As far as I understood, it's a cosmetic feature: the inputs are hidden in the UI.

Currently the pr #2033 removes the whole input from the trigger to hide it in the UI. This also requires that references to these inputs are replaced with their literal values.
But inputs for workflow_call should not be removed, because calls could use these inputs. But even if they are not removed they would not be used because their references are missing.

I suggest ignoring this issue for this PR and moving the discussion on this topic to PR #2033?

If this pr is something that gets implemented we would need another solution. A possible solution could be to split the update workflow into two workflows:

New reusable workflow

Copy of current workflow

Only workflow_call instead of workflow_dispatch

Additional input for original event name

References to original event name from input instead of event name

Current workflow

Only workflow_dispatch (as is)

Only contains calls of reusable workflow with passthru of the inputs

This would allow the new default inputs to be applied to the dispatch workflow without breaking the call workflow. A problem with this would be that other calls of the reusable workflow would not inherit the default settings. To work around this we could set the inputs of the reusable workflow as required without default values.
What do you think?

I do think this could be the right approach long term, but it requires way more investment, testing, etc. "Update AL-Go" is quite an important process and must not break.

I’m of the same opinion.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RELEASENOTES.md

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* Apply workflow default inputs to call inputs with matching dispatch inputs * Update teste for action CheckForUpdates * Updated documentation for "workflowDefaultInputs"

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

OleWunschmann · 2025-12-11T19:18:52Z

@mazhelez
I implemented the suggested change for the workflow default inputs.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Actions/CheckForUpdates/CheckForUpdates.HelperFunctions.ps1

…nputs

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Tests/CheckForUpdates.Action.Test.ps1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Tests/CheckForUpdates.Action.Test.ps1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Add event 'workflow_call' to workflow 'UpdateGitHubGoSystemFiles' for…

aa93724

… reusability

Copilot AI review requested due to automatic review settings November 19, 2025 19:52

OleWunschmann requested a review from a team as a code owner November 19, 2025 19:52

Copilot started reviewing on behalf of OleWunschmann November 19, 2025 19:52 View session

Copilot finished reviewing on behalf of OleWunschmann November 19, 2025 19:54

Copilot AI reviewed Nov 19, 2025

View reviewed changes

Ole Wunschmenn and others added 2 commits November 19, 2025 20:54

Add event 'workflow_call' to workflow 'UpdateGitHubGoSystemFiles' for…

a2dd4f6

… reusability

Merge branch 'main' into update-workflow-reusable

7f3cab2

Copilot AI mentioned this pull request Dec 3, 2025

Add PowerShell script to add review comments on PRs modifying release notes #2058

Open

4 tasks

OleWunschmann and others added 2 commits December 8, 2025 17:08

Merge branch 'main' into update-workflow-reusable

a94e040

Merge branch 'main' into update-workflow-reusable

9c235be

mazhelez requested a review from Copilot December 9, 2025 10:01

Copilot started reviewing on behalf of mazhelez December 9, 2025 10:02 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

RELEASENOTES.md Outdated Show resolved Hide resolved

mazhelez requested a review from Copilot December 10, 2025 07:23

Copilot started reviewing on behalf of mazhelez December 10, 2025 07:23 View session

Copilot AI reviewed Dec 10, 2025

View reviewed changes

OleWunschmann and others added 4 commits December 11, 2025 20:06

Apply workflow default inputs to workflow_call inputs (#1)

563a90f

* Apply workflow default inputs to call inputs with matching dispatch inputs * Update teste for action CheckForUpdates * Updated documentation for "workflowDefaultInputs"

Update RELEASENOTES.md

52ef2a5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update RELEASENOTES.md

fbf40e8

Update RELEASENOTES.md

9e1d971

Merge branch 'main' into update-workflow-reusable

8bb68fc

OleWunschmann requested a review from Copilot December 11, 2025 19:23

Copilot started reviewing on behalf of OleWunschmann December 11, 2025 19:23 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Actions/CheckForUpdates/CheckForUpdates.HelperFunctions.ps1 Outdated Show resolved Hide resolved

Actions/CheckForUpdates/CheckForUpdates.HelperFunctions.ps1 Outdated Show resolved Hide resolved

Actions/CheckForUpdates/CheckForUpdates.HelperFunctions.ps1 Outdated Show resolved Hide resolved

Apply workflow default inputs to call inputs with matching dispatch i…

0cdcde0

…nputs

OleWunschmann requested a review from Copilot December 11, 2025 21:21

Copilot started reviewing on behalf of OleWunschmann December 11, 2025 21:21 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Tests/CheckForUpdates.Action.Test.ps1 Outdated Show resolved Hide resolved

Update Tests/CheckForUpdates.Action.Test.ps1

71cb8eb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

mazhelez requested a review from Copilot December 12, 2025 10:29

Copilot started reviewing on behalf of mazhelez December 12, 2025 10:30 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

Tests/CheckForUpdates.Action.Test.ps1 Outdated Show resolved Hide resolved

mazhelez previously approved these changes Dec 12, 2025

View reviewed changes

Update Tests/CheckForUpdates.Action.Test.ps1

ecda769

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

OleWunschmann dismissed mazhelez’s stale review via ecda769 December 12, 2025 11:09

Update Tests for strict mode

61e21af

mazhelez requested a review from Copilot December 15, 2025 13:41

Copilot started reviewing on behalf of mazhelez December 15, 2025 13:42 View session

mazhelez approved these changes Dec 15, 2025

View reviewed changes

Merge branch 'main' into update-workflow-reusable

6eb03ab

mazhelez requested a review from aholstrup1 December 15, 2025 13:42

Copilot AI reviewed Dec 15, 2025

View reviewed changes

Merge branch 'main' into update-workflow-reusable

c31be78

aholstrup1 approved these changes Dec 17, 2025

View reviewed changes

aholstrup1 merged commit 23b5dde into microsoft:main Dec 17, 2025
6 checks passed

Add trigger 'workflow_call' to workflow 'UpdateGitHubGoSystemFiles' for reusability #2031

Add trigger 'workflow_call' to workflow 'UpdateGitHubGoSystemFiles' for reusability #2031

Uh oh!

Conversation

OleWunschmann commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❔What, Why & How

✅ Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

mazhelez commented Nov 20, 2025

Uh oh!

OleWunschmann commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mazhelez commented Nov 24, 2025

Uh oh!

mazhelez commented Dec 3, 2025

⚠️ Release Notes Update Reminder

Uh oh!

OleWunschmann commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

OleWunschmann commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OleWunschmann commented Nov 19, 2025 •

edited

Loading

OleWunschmann commented Nov 20, 2025 •

edited

Loading