Allow release creation for projects containing only test apps#2215
Conversation
Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/113d51d9-e145-4f4d-a43f-630553dfd8a8 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
|
@copilot the proposed solution would include test artifacts in the release, which may be an unwanted side effect. |
Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/414c08ff-4c95-4a7a-8b8f-391414752ac6 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Good point. Reverted the filter change and instead relaxed the check: when a project has no |
There was a problem hiding this comment.
Pull request overview
Updates the release creation workflow logic so projects that only produce test artifacts don’t block creating a release for other projects in the repo.
Changes:
- Adjust
DetermineArtifactsForReleaseto warn + skip a project when onlyTestAppsartifacts exist (instead of failing immediately). - Add an entry to
RELEASENOTES.mdfor Issue 2211.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Actions/DetermineArtifactsForRelease/DetermineArtifactsForRelease.ps1 |
Skips projects with only test artifacts to allow release creation to proceed for other projects. |
RELEASENOTES.md |
Documents the fix under Issues. |
…ase.ps1 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/e1f0a039-a64d-4325-8735-c5761e8c3adf Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/AL-Go/sessions/9361538b-0adf-4477-be91-ede701462354 Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
This was already addressed in 89e6159: the artifact filter is unchanged, and instead the check is relaxed — projects with only test artifacts now log a warning and are skipped, so test artifacts are not included in the release. |
|
@copilot resolve the merge conflicts in this pull request |
…orkflow-error # Conflicts: # RELEASENOTES.md Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
❔What, Why & How
DetermineArtifactsForReleaseresolved each project's build version by looking up anApps-*orPowerPlatformSolution-*artifact. Projects that only produce aTestApps-*artifact never matched, so the release workflow aborted withNo artifacts found for this project.Actions/DetermineArtifactsForRelease/DetermineArtifactsForRelease.ps1:Apps/PowerPlatformSolutionartifact is found for a project but a test artifact exists, log a warning and skip the project instead of failing. Test artifacts are intentionally not added to the release. If no artifacts of any kind are found for the project, the original error is still raised.*TestApps-*so build-mode prefixes (e.g.CleanTestApps,TranslatedTestApps) are also recognized.$include.Count -eq 0or empty$sha), so downstream workflow steps don't fail with a confusing empty matrix / empty commitish.Tests/DetermineArtifactsForRelease.Test.ps1: add Pester tests that mock the GitHub artifacts/branches APIs and cover: (1) mixed projects with apps + test artifacts produce a non-empty include list, (2) a test-only project is skipped with a::Warning::(including build-mode prefixes likeCleanTestApps), (3) a clear error is thrown when no project has releasable artifacts, and (4) the originalNo artifacts found for this projecterror is still raised when a project has no artifacts at all.RELEASENOTES.md: note the fix under Issues.maininto the branch and resolved the conflict inRELEASENOTES.md(kept both Issue 2211 and Issue 2214 entries).✅ Checklist