Skip settings schema validation on PS5.1 when JSON exceeds command-line length limit

[Copilot]

❔What, Why & How

On PS5.1, ValidateSettings shells out to pwsh.exe passing the full settings JSON as a command-line argument. For repositories with many projects/settings, the JSON can exceed the ~32K Windows command-line limit, producing:

Error validating settings. Error: Program 'pwsh.exe' failed to run: The filename or extension is too long

Fix: Silently skip schema validation on the PS5.1 code path when $settingsJson.Length > 30000. Uses continue instead of return to ensure subsequent piped settings objects are still validated. The PS7+ in-process Invoke-Command path is unaffected since it passes the JSON without command-line length constraints.

✅ Checklist

• Add tests (E2E, unit tests) — added Pester test verifying oversized JSON skips pwsh invocation on PS5.1 and produces no warning
• Update RELEASENOTES.md
• Update documentation (e.g. for new settings or scenarios)
• Add telemetry

[Copilot]

Pull request overview

This PR addresses a Windows PowerShell 5.1 limitation where ValidateSettings shells out to pwsh and can exceed the Windows ~32K command-line length limit when passing large settings JSON, causing validation to fail.

Changes:

• Add a PS5.1 guard to skip settings schema validation when the serialized settings JSON is larger than 30,000 characters.
• Update release notes to document the fix for the “filename or extension is too long” validation error.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
RELEASENOTES.md	Documents the PS5.1 validation-length-limit fix in the Issues list.
Actions/.Modules/ReadSettings.psm1	Adds an early-exit condition in ValidateSettings for PS5.1 when settings JSON is very large.

[mazhelez]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Applied all three changes from the review in commit bb500e1:

1. Changed return → continue in the Process block so subsequent piped items still get validated.
2. Added an OutputWarning explaining that schema validation was skipped due to the PS5.1 command-line length limit.
3. Added a unit test in Tests/ReadSettings.Test.ps1 that verifies oversized JSON skips validation (with warning on PS5.1, or runs in-process without skipping on PS7+). All 12 ReadSettings tests pass.

[mazhelez]

@copilot ValidateSettings never throws. At most it outputs a warning.

[Copilot]

Fixed in 15e5296 — removed the Should -Not -Throw wrappers and just call ValidateSettings directly.

[mazhelez]

@copilot I think you need to verify that no warning is output

[Copilot]

Added a Should -Invoke -CommandName Write-Host -Times 0 -ParameterFilter { $Object -like '*::Warning::*' } assertion in 89a6b4a to verify no warning is output.