[Event Requests] - Codeunit 7000 "Sales Price Calc. Mgt."

[exnihiloo]

Why do you need this change?

1. Procedure SalesLinePriceExists
   The integration event OnBeforeSalesLinePriceExists currently lacks sufficient sender/context parameters, even though it is invoked from the procedure SalesLinePriceExists, which itself is called from multiple places within Sales Price Calc. Mgt. and relies on already-initialized global variables.
   This limits the ability for extensions to correctly react depending on the caller and current calculation context.
   SalesLinePriceExists is invoked from multiple entry points
   Global variables (Qty, QtyPerUOM, currency context, etc.) are already initialized at this stage
   Alternatives Evaluated:
   Existing pricing events were reviewed, but:
   No other event fires at the same execution point with access to initialized global state
   Performance Considerations:
   Event is already executed as part of pricing checks
   Adding parameters does not add logic, loops, or database access
   No measurable performance impact expected
   Data Sensitivity Review:
   Only existing session records (Sales Header, Sales Line, temp pricing data) are exposed
   No additional data, no crossΓÇæcompany access
   No security or privacy concerns identified
2. Procedure SalesLineLineDiscExists
   The integration event OnBeforeSalesLineLineDiscExists currently lacks sufficient sender/context parameters, even though it is invoked from the procedure SalesLineLineDiscExists, which itself is called from multiple places within Sales Price Calc. Mgt. and relies on already-initialized global variables.
   This limits the ability for extensions to correctly react depending on the caller and current calculation context.
   SalesLineLineDiscExistsis invoked from multiple entry points
   Global variables (Qty, QtyPerUOM, currency context, etc.) are already initialized at this stage
   Alternatives Evaluated:
   Existing pricing events were reviewed, but:
   No other event fires at the same execution point with access to initialized global state
   Performance Considerations:
   Event is already executed as part of pricing checks
   Adding parameters does not add logic, loops, or database access
   No measurable performance impact expected
   Data Sensitivity Review:
   Only existing session records (Sales Header, Sales Line, temp pricing data) are exposed
   No additional data, no crossΓÇæcompany access
   No security or privacy concerns identified

Describe the request

1. Event OnBeforeSalesLinePriceExists
   current:

[IntegrationEvent(false, false)]
    local procedure OnBeforeSalesLinePriceExists(var SalesLine: Record "Sales Line"; var SalesHeader: Record "Sales Header"; var TempSalesPrice: Record "Sales Price" temporary; Currency: Record Currency; CurrencyFactor: Decimal; StartingDate: Date; Qty: Decimal; QtyPerUOM: Decimal; ShowAll: Boolean; var InHandled: Boolean)
    begin
    end;

modified:

[IntegrationEvent(true, false)] //Include sender on event
    local procedure OnBeforeSalesLinePriceExists(var SalesLine: Record "Sales Line"; var SalesHeader: Record "Sales Header"; var TempSalesPrice: Record "Sales Price" temporary; Currency: Record Currency; CurrencyFactor: Decimal; StartingDate: Date; Qty: Decimal; QtyPerUOM: Decimal; ShowAll: Boolean; var InHandled: Boolean)
    begin
    end;

alternative (add "Sales Price Calc. Mgt." codeunit to parameter):

[IntegrationEvent(false, false)] 
    local procedure OnBeforeSalesLinePriceExists(var SalesLine: Record "Sales Line"; var SalesHeader: Record "Sales Header"; var TempSalesPrice: Record "Sales Price" temporary; Currency: Record Currency; CurrencyFactor: Decimal; StartingDate: Date; Qty: Decimal; QtyPerUOM: Decimal; ShowAll: Boolean; var InHandled: Boolean; this: Codeunit "Sales Price Calc. Mgt.")
    begin
    end;

2. Event OnBeforeSalesLineLineDiscExists

[IntegrationEvent(false, false)]
    local procedure OnBeforeSalesLineLineDiscExists(var SalesLine: Record "Sales Line"; var SalesHeader: Record "Sales Header"; var TempSalesLineDisc: Record "Sales Line Discount" temporary; StartingDate: Date; Qty: Decimal; QtyPerUOM: Decimal; ShowAll: Boolean; var IsHandled: Boolean)
    begin
    end;

modified:

[IntegrationEvent(true, false)] //Include sender on event
    local procedure OnBeforeSalesLineLineDiscExists(var SalesLine: Record "Sales Line"; var SalesHeader: Record "Sales Header"; var TempSalesLineDisc: Record "Sales Line Discount" temporary; StartingDate: Date; Qty: Decimal; QtyPerUOM: Decimal; ShowAll: Boolean; var IsHandled: Boolean)
    begin
    end;

alternative (add "Sales Price Calc. Mgt." codeunit to parameter):

[IntegrationEvent(false, false)] 
    local procedure OnBeforeSalesLineLineDiscExists(var SalesLine: Record "Sales Line"; var SalesHeader: Record "Sales Header"; var TempSalesLineDisc: Record "Sales Line Discount" temporary; StartingDate: Date; Qty: Decimal; QtyPerUOM: Decimal; ShowAll: Boolean; var IsHandled: Boolean; this: Codeunit "Sales Price Calc. Mgt.")
    begin
    end;

Internal work item: AB#631593

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Update the existing OnBeforeSalesLinePriceExists and OnBeforeSalesLineLineDiscExists integration events in Codeunit 7000 "Sales Price Calc. Mgt." to include the sender so subscribers can access the current codeunit context.

Location in SalesLinePriceExists() and SalesLineLineDiscExists() procedures:

procedure SalesLinePriceExists(var SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line"; ShowAll: Boolean) Result: Boolean
var
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeSalesLinePriceExistsProcedure(SalesHeader, SalesLine, ShowAll, TempSalesPrice, Result, IsHandled);
    if IsHandled then
        exit(Result);

    if (SalesLine.Type = SalesLine.Type::Item) and Item.Get(SalesLine."No.") then begin
        IsHandled := false;
        OnBeforeSalesLinePriceExists(
          SalesLine, SalesHeader, TempSalesPrice, Currency, CurrencyFactor,
          SalesHeaderStartDate(SalesHeader, DateCaption), Qty, QtyPerUOM, ShowAll, IsHandled);
        if not IsHandled then begin
            FindSalesPrice(...);
            OnAfterSalesLinePriceExists(SalesLine, SalesHeader, TempSalesPrice, ShowAll);
        end;
        exit(TempSalesPrice.FindFirst());
    end;
end;

procedure SalesLineLineDiscExists(var SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line"; ShowAll: Boolean): Boolean
var
    IsHandled: Boolean;
begin
    if (SalesLine.Type = SalesLine.Type::Item) and Item.Get(SalesLine."No.") then begin
        IsHandled := false;
        OnBeforeSalesLineLineDiscExists(
          SalesLine, SalesHeader, TempSalesLineDisc, SalesHeaderStartDate(SalesHeader, DateCaption),
          Qty, QtyPerUOM, ShowAll, IsHandled);
        if not IsHandled then begin
            FindSalesLineDisc(...);
            OnAfterSalesLineLineDiscExists(SalesLine, SalesHeader, TempSalesLineDisc, ShowAll);
        end;
        exit(TempSalesLineDisc.FindFirst())
    end;
    exit(false);
end;

Event Publisher (add at the end of the codeunit with other events):

[IntegrationEvent(true, false)]
local procedure OnBeforeSalesLineLineDiscExists(var SalesLine: Record "Sales Line"; var SalesHeader: Record "Sales Header"; var TempSalesLineDisc: Record "Sales Line Discount" temporary; StartingDate: Date; Qty: Decimal; QtyPerUOM: Decimal; ShowAll: Boolean; var IsHandled: Boolean)
begin
end;

[IntegrationEvent(true, false)]
local procedure OnBeforeSalesLinePriceExists(var SalesLine: Record "Sales Line"; var SalesHeader: Record "Sales Header"; var TempSalesPrice: Record "Sales Price" temporary; Currency: Record Currency; CurrencyFactor: Decimal; StartingDate: Date; Qty: Decimal; QtyPerUOM: Decimal; ShowAll: Boolean; var InHandled: Boolean)
begin
end;

---

File: SalesPriceCalcMgt.Codeunit.al