[Request for External] Make GetItem() and GetItemUnitOfMeasure() procedures public in Report 5756 "Create Warehouse Location"

[jasonchen-sudo]

Why do you need this change?

We would like to customise logic around TempWhseJnlLine."Unit of Measure Code" assignment inside CreateWhseJnlLine() in Report 5756 "Create Warehouse Location" , so we would need to expose GetItem() and GetItemUnitOfMeasure() procedures which are both currently local along with the event request here #30098 .

Describe the request

Hi,

Following the issue #30098, can we please expose both GetItem() and GetItemUnitOfMeasure() procedures in Report 5756 "Create Warehouse Location" to be external so they could get called from outside?

    local procedure GetItem(ItemNo: Code[20])
    begin
        if Item."No." <> ItemNo then
            Item.Get(ItemNo);
    end;

    local procedure GetItemUnitOfMeasure(ItemNo: Code[20]; UOMCode: Code[10])
    begin
        if (ItemUnitOfMeasure."Item No." <> ItemNo) or
           (ItemUnitOfMeasure.Code <> UOMCode)
        then
            if not ItemUnitOfMeasure.Get(ItemNo, UOMCode) then
                ItemUnitOfMeasure.Init();
    end;

Regards,
Jason
Internal work item: AB#636121

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Make GetItem() and GetItemUnitOfMeasure() procedures public in Report 5756 "Create Warehouse Location" by removing the local keyword.

1. GetItem() - Current code:

local procedure GetItem(ItemNo: Code[20])
begin
    if Item."No." <> ItemNo then
        Item.Get(ItemNo);
end;

Proposed change:

procedure GetItem(ItemNo: Code[20])
begin
    if Item."No." <> ItemNo then
        Item.Get(ItemNo);
end;

2. GetItemUnitOfMeasure() - Current code:

local procedure GetItemUnitOfMeasure(ItemNo: Code[20]; UOMCode: Code[10])
begin
    if (ItemUnitOfMeasure."Item No." <> ItemNo) or
       (ItemUnitOfMeasure.Code <> UOMCode)
    then
        if not ItemUnitOfMeasure.Get(ItemNo, UOMCode) then
            ItemUnitOfMeasure.Init();
end;

Proposed change:

procedure GetItemUnitOfMeasure(ItemNo: Code[20]; UOMCode: Code[10])
begin
    if (ItemUnitOfMeasure."Item No." <> ItemNo) or
       (ItemUnitOfMeasure.Code <> UOMCode)
    then
        if not ItemUnitOfMeasure.Get(ItemNo, UOMCode) then
            ItemUnitOfMeasure.Init();
end;

---

File: CreateWarehouseLocation.Report.al

[AleksandricMarko]

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.