[Event Request] codeunit 444 "Purchase-Post Prepayments" - UpdatePrepmtAmountOnPurchLines procedure

[tuan-nguyen-fenwick]

Why do you need this change?

We would like to request the addition of 3 new integration events to further enhance the extensibility of the UpdatePrepmtAmountOnPurchLines procedure in Base Application.

The existing implementation does not provide sufficient extension points to control key parts of the prepayment update process. Specifically, we are not able to:

• Adjust or override the filters applied when retrieving prepayment sales lines.
• Handle scenarios where no prepayment lines exist without triggering an error.
• Run custom logic before individual sales lines are updated.

Describe the request

The 3 new proposed events that we would like to add at the end of the PurchasePostPrepayments.Codeunit.al object are:

    [IntegrationEvent(false, false)]
    local procedure OnUpdatePrepmtAmountOnPurchLinesOnAfterSetFilters(var PurchLine: Record "Purchase Line"; PurchHeader: Record "Purchase Header"; var NewTotalPrepmtAmount: Decimal)
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnUpdatePrepmtAmountOnPurchLinesOnBeforeErrorIfLinesNotFound(var PurchLine: Record "Purchase Line"; PurchHeader: Record "Purchase Header"; var RaiseError: Boolean)
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnUpdatePrepmtAmountOnPurchLinesOnBeforeModify(var PurchLine: Record "Purchase Line"; PurchHeader: Record "Purchase Header"; var NewTotalPrepmtAmount: Decimal; var TotalPrepmtAmount: Decimal)
    begin
    end;

Event 1: OnUpdatePrepmtAmountOnPurchLinesOnAfterSetFilters should be added after filters are set and right before the table is locked. This allows extensions to adjust filters prior to processing and provides a safe hook before record locking occurs.

Event 2: OnUpdatePrepmtAmountOnPurchLinesOnBeforeErrorIfLinesNotFound should be added after attempting to retrieve prepayment purchase lines, when no lines are found. This enables subscribers to suppress the standard error. Introduces a RaiseError variable and the default behaviour remains unchanged by setting it to RaiseError = true

Event 3: OnUpdatePrepmtAmountOnPurchLinesOnBeforeModify should be immediately before each line record is modified. This allows extensions to adjust values prior to modification.

[AleksandricMarko]

Hi @tuan-nguyen-fenwick,

Thanks for submitting this extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Event in Loop — Performance Justification (Event 3): The proposed event OnUpdatePrepmtAmountOnPurchLinesOnBeforeModify is placed inside a repeat...until loop, which means it will fire for every purchase line being modified. This may cause performance issues if subscribers perform heavy operations. Please address the following:
  1. Why must the event fire on each iteration rather than once before or after the loop?
  2. What operations will subscribers perform in the event handler?
  3. Have you considered alternative placements (e.g., a single event before or after the loop)?

Please update the issue with the missing details. We'll automatically re-analyze once updated.

[tuan-nguyen-fenwick]

Hi @tuan-nguyen-fenwick,

Thanks for submitting this extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Event in Loop — Performance Justification (Event 3): The proposed event OnUpdatePrepmtAmountOnPurchLinesOnBeforeModify is placed inside a repeat...until loop, which means it will fire for every purchase line being modified. This may cause performance issues if subscribers perform heavy operations. Please address the following:

  1. Why must the event fire on each iteration rather than once before or after the loop?
  2. What operations will subscribers perform in the event handler?
  3. Have you considered alternative placements (e.g., a single event before or after the loop)?

Please update the issue with the missing details. We'll automatically re-analyze once updated.

Same as this reply but for purchases: #30110 (comment)

[github-actions]

Hi @tuan-nguyen-fenwick,

Thank you for your extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Alternative approaches considered: Explain which existing events or other extensibility patterns were evaluated and why they are insufficient for this scenario.
• Bypass/control-flow justification: Explain why the standard behavior must be skipped or overridden, especially for the proposed OnBeforeErrorIfLinesNotFound event.
• Event in loop - performance justification: Include the actual justification in this issue for why OnUpdatePrepmtAmountOnPurchLinesOnBeforeModify must run on every iteration, what subscriber logic will do there, and why before/after-loop alternatives are not sufficient.
• Data sensitivity and extension interaction review: Provide an assessment of any data sensitivity concerns and how the proposed events should behave when multiple extensions subscribe and potentially conflict.

Please update the issue with the missing details. We'll automatically re-analyze once updated.

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.

[tuan-nguyen-fenwick]

Hi @tuan-nguyen-fenwick,

Thank you for your extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Alternative approaches considered: Explain which existing events or other extensibility patterns were evaluated and why they are insufficient for this scenario.
• Bypass/control-flow justification: Explain why the standard behavior must be skipped or overridden, especially for the proposed OnBeforeErrorIfLinesNotFound event.
• Event in loop - performance justification: Include the actual justification in this issue for why OnUpdatePrepmtAmountOnPurchLinesOnBeforeModify must run on every iteration, what subscriber logic will do there, and why before/after-loop alternatives are not sufficient.
• Data sensitivity and extension interaction review: Provide an assessment of any data sensitivity concerns and how the proposed events should behave when multiple extensions subscribe and potentially conflict.

Please update the issue with the missing details. We'll automatically re-analyze once updated.

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.

• Existing events or alternative patterns considered: There's no other alternative without having to duplicate the entire UpdatePrepmtAmountOnPurchLines function.
• Bypass/suppress behavior justification: We don't have to bypass all errors being thrown in the function. Only the error that occurs when there is no prepayment line found.
• Data sensitivity statement: No.
• Multi-extension interaction or conflict risk: Minimal

[github-actions]

Hi @tuan-nguyen-fenwick,

Thank you for your extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Event in loop - performance justification: Explain in this issue why OnUpdatePrepmtAmountOnPurchLinesOnBeforeModify must run on every iteration, what subscriber logic will execute there, what the expected execution frequency and performance impact are, and why before-loop or after-loop alternatives are insufficient.

Please update the issue with the missing details. We'll automatically re-analyze once updated.

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.