-
Notifications
You must be signed in to change notification settings - Fork 687
E-Document: Change accessibility level for EDoc WorkFlow #28359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Issue #28326 is not valid. Please make sure you link an issue that exists, is open and is approved. |
Groenbech96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change then we can merge it in.
|
|
||
| codeunit 6139 "E-Document Workflow Setup" | ||
| { | ||
| Access = Internal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the EDocReceived, EDocImport and EDocStatusChanged internal.
|
Hi @Groenbech96. That makes no sense. I will try to explain the issue further: The codeunit has the following internal procedures (Which can ONLY be called in this app): Of these, I want to be able to have the 5 procedures public (For me to be able to avoid hardcoding the vales in my app): In order to do this, I have to change the access of the whole object to This PR does exactly this. Another way could have been to create a new codeunit and then expose those 5 procedures. Hope to hear from you. Thank you! |
Let me try and explain my reasoning: |
|
Thank you for the explaination @Groenbech96, that helped. |
Groenbech96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
|
merged internally. targeted for 26.2 |
Summary
Enables access to hardcoded WorkFlow-names.
The changed code does not change the actual functions I want exposed, since the whole object is now Public. The functions I want are
EDocReceived,EDocImport,EDocSendEDocResponseCode,EDocCreated&EDocStatusChangedWork Item(s)
Fixes #28326