Skip to content

fix: Replace LoadFields with AddLoadFields in APIV2 pages #29955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffreybulanadi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Replace LoadFields with AddLoadFields in APIV2 pages #29955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Apps/W1/APIV2/app/src/pages/APIV2BankAccounts.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,11 @@ page 30051 "APIV2 - Bank Accounts"
CurrencyCodeDoesNotMatchACurrencyErr: Label 'The "currencyCode" does not match to a Currency.', Comment = 'currencyCode is a field name and should not be translated.';
CurrencyValuesDontMatchErr: Label 'The currency values do not match to a specific Currency.';

trigger OnOpenPage()
begin
Rec.AddLoadFields("Currency Code");
end;

trigger OnAfterGetRecord()
begin
LoadCurrencyInformation();
Expand All @@ -127,7 +132,6 @@ page 30051 "APIV2 - Bank Accounts"
var
GraphMgtGeneralTools: Codeunit "Graph Mgt - General Tools";
begin
Rec.LoadFields("Currency Code");
CurrencyCodeTxt := GraphMgtGeneralTools.TranslateNAVCurrencyCodeToCurrencyCode(LCYCurrencyCode, Rec."Currency Code");
end;
}
2 changes: 1 addition & 1 deletion Apps/W1/APIV2/app/src/pages/APIV2PurchaseCreditMemos.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,7 @@ page 30083 "APIV2 - Purchase Credit Memos"
begin
CheckDataUpgrade();
SetPermissionsFilters();
Rec.AddLoadFields("Applies-to Doc. Type", "Currency Code");
end;

var
Expand Down Expand Up @@ -670,7 +671,6 @@ page 30083 "APIV2 - Purchase Credit Memos"

local procedure SetCalculatedFields()
begin
Rec.LoadFields("Applies-to Doc. Type", "Currency Code");
SetInvoiceId();
CurrencyCodeTxt := GraphMgtGeneralTools.TranslateNAVCurrencyCodeToCurrencyCode(LCYCurrencyCode, Rec."Currency Code");
end;
Expand Down
2 changes: 1 addition & 1 deletion Apps/W1/APIV2/app/src/pages/APIV2PurchaseInvoices.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,6 +595,7 @@ page 30042 "APIV2 - Purchase Invoices"
trigger OnOpenPage()
begin
CheckPermissions();
Rec.AddLoadFields("Currency Code");
end;

var
Expand Down Expand Up @@ -622,7 +623,6 @@ page 30042 "APIV2 - Purchase Invoices"

local procedure SetCalculatedFields()
begin
Rec.LoadFields("Currency Code");
CurrencyCodeTxt := GraphMgtGeneralTools.TranslateNAVCurrencyCodeToCurrencyCode(LCYCurrencyCode, Rec."Currency Code");
end;

Expand Down
2 changes: 1 addition & 1 deletion Apps/W1/APIV2/app/src/pages/APIV2SalesCreditMemos.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,7 @@ page 30038 "APIV2 - Sales Credit Memos"
trigger OnOpenPage()
begin
SetPemissionsFilters();
Rec.AddLoadFields("Applies-to Doc. Type", "Currency Code");
end;

var
Expand Down Expand Up @@ -691,7 +692,6 @@ page 30038 "APIV2 - Sales Credit Memos"

local procedure SetCalculatedFields()
begin
Rec.LoadFields("Applies-to Doc. Type", "Currency Code");
SetInvoiceId();
CurrencyCodeTxt := GraphMgtGeneralTools.TranslateNAVCurrencyCodeToCurrencyCode(LCYCurrencyCode, Rec."Currency Code");
end;
Expand Down
2 changes: 1 addition & 1 deletion Apps/W1/APIV2/app/src/pages/APIV2SalesInvoices.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,7 @@ page 30012 "APIV2 - Sales Invoices"
trigger OnOpenPage()
begin
SetPermissionFilters();
Rec.AddLoadFields("No.", "Currency Code", "Amount Including VAT", Posted, Status);
end;

var
Expand Down Expand Up @@ -772,7 +773,6 @@ page 30012 "APIV2 - Sales Invoices"

local procedure SetCalculatedFields()
begin
Rec.LoadFields("No.", "Currency Code", "Amount Including VAT", Posted, Status);
GetRemainingAmount();
CurrencyCodeTxt := GraphMgtGeneralTools.TranslateNAVCurrencyCodeToCurrencyCode(LCYCurrencyCode, Rec."Currency Code");
end;
Expand Down
2 changes: 1 addition & 1 deletion Apps/W1/APIV2/app/src/pages/APIV2SalesQuotes.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,7 @@ page 30037 "APIV2 - Sales Quotes"
trigger OnOpenPage()
begin
CheckPermissions();
Rec.AddLoadFields("Currency Code");
end;

var
Expand Down Expand Up @@ -717,7 +718,6 @@ page 30037 "APIV2 - Sales Quotes"

local procedure SetCalculatedFields()
begin
Rec.LoadFields("Currency Code");
CurrencyCodeTxt := GraphMgtGeneralTools.TranslateNAVCurrencyCodeToCurrencyCode(LCYCurrencyCode, Rec."Currency Code");
end;

Expand Down
Loading