Skip to content
This repository was archived by the owner on Sep 21, 2024. It is now read-only.

Conversation

@nlebeck
Copy link
Contributor

@nlebeck nlebeck commented Jan 18, 2019

This commit does a few different things to polish the UWPExample solution:

  1. Adds quick start instructions to the README for compiling and running the UWPExample apps.
  2. Changes the GraphicalApp and GraphicalAppUWP projects to use the term "instance" instead of "service," matching our current Ambrosia terminology.
  3. Improves the error messages in the UWPExample codegen script.

This PR should only touch files in the UWPExample directory, so it shouldn't have any effect on the core Ambrosia code.

Earlier in development, Ambrosia "instances" were referred to as "services."
This commit changes the UWPExample UI code to use "instance" in variable names
and labels in order to match the new terminology.
Copy link
Collaborator

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some changes in the codegen PS scripts. You can copy over the scheme from any of the other examples :)

@nlebeck
Copy link
Contributor Author

nlebeck commented Jan 21, 2019

There were some changes in the codegen PS scripts. You can copy over the scheme from any of the other examples :)

I changed the codegen script to remove the stuff related to the CodeGenDependencies directory. Is there anything else you wanted me to grab from the other scripts? I intentionally left out the AMBVARIANT and AMBROSIATOOLS environment variables from this codegen script, since building the UWPExample solution requires building Ambrosia from source and building the Ambrosia net46 target.

@nlebeck nlebeck merged commit 43f0764 into master Jan 23, 2019
@nlebeck nlebeck deleted the nlebeck/uwp-cleanup-quickstart branch February 1, 2019 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants