Skip to content

[Designer] Add aria attributes to dropdown controls#4171

Merged
paulcam206 merged 2 commits into
mainfrom
paulcam/combobox-aria
Jun 12, 2020
Merged

[Designer] Add aria attributes to dropdown controls#4171
paulcam206 merged 2 commits into
mainfrom
paulcam/combobox-aria

Conversation

@paulcam206

@paulcam206 paulcam206 commented Jun 12, 2020 •
edited by ghost
Loading

Copy link
Copy Markdown
Member

Related Issue

Fixes VSO #24095594
Fixes VSO #24113643
Fixes VSO #24081494

Description

A few fixes:

  • The "Preview Mode" toolbar button now gets the aria-pressed property set appropriately set
  • The toolbar dropdown menus are now marked up correctly for accessibility
  • Keyboard access to peer comboboxes now works

How Verified

  • local build, narrator, dev tools, keyboard
Microsoft Reviewers: Open in CodeFlow

@paulcam206
[Designer] Add aria attributes to dropdown controls
db9735b 
Fixes VSO #24095594
Fixes VSO #24113643
Fixes VSO #24081494
@paulcam206 paulcam206 added Platform-JavaScript Bugs or features related to the JavaScript renderer Area-Accessibility Bugs around feature accessibility labels Jun 12, 2020
@ghost

ghost commented Jun 12, 2020

Copy link
Copy Markdown

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

dclaux
dclaux approved these changes Jun 12, 2020
View reviewed changes
Comment thread source/nodejs/adaptivecards-controls/src/inputwithpopup.ts
Comment thread source/nodejs/adaptivecards-designer/src/toolbar.ts
Comment thread source/nodejs/adaptivecards-controls/src/dropdown.ts Outdated
shalinijoshi19
shalinijoshi19 approved these changes Jun 12, 2020
View reviewed changes

@shalinijoshi19 shalinijoshi19 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shalinijoshi19

shalinijoshi19 commented Jun 12, 2020 •
edited
Loading

Copy link
Copy Markdown

@paulcam206 I've been labeling the accessibility bug fixes that need to go out as patches to the release/1.2 with AdaptiveCards v1.2.10 label. Please remove this label if this doesn't need to be patched and ported over to release/1.2. Thanks!
Also should we create a single backing issue for these buckets of bug fixes per our own Contributing.md that you can reference here (in addition to the ADO references) ?

@paulcam206 paulcam206 merged commit 53c7594 into main Jun 12, 2020
@paulcam206 paulcam206 deleted the paulcam/combobox-aria branch June 12, 2020 16:34
@ghost

ghost commented Jul 7, 2020

Copy link
Copy Markdown

🎉AdaptiveCards@2020.06 has been released which fixes this issue.:tada:

Handy links:

@shalinijoshi19 shalinijoshi19 added this to the 20.06 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dclaux dclaux dclaux approved these changes
@matthidinger matthidinger Awaiting requested review from matthidinger
+1 more reviewer
@shalinijoshi19 shalinijoshi19 shalinijoshi19 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Accessibility Bugs around feature accessibility Platform-JavaScript Bugs or features related to the JavaScript renderer

Projects

None yet

Milestone

20.06

Development

Successfully merging this pull request may close these issues.

3 participants

@paulcam206 @shalinijoshi19 @dclaux