Skip to content

[JS] Express action sets as collections#4184

Merged
paulcam206 merged 1 commit into
mainfrom
paulcam/actionset-aria
Jun 16, 2020
Merged

[JS] Express action sets as collections#4184
paulcam206 merged 1 commit into
mainfrom
paulcam/actionset-aria

Conversation

@paulcam206

@paulcam206 paulcam206 commented Jun 16, 2020

Copy link
Copy Markdown
Member

Related Issue

Fixes VSO #24019554

Description

Before this change, each Action in an ActionSet was considered in isolation by accessibility. There was no way of knowing how many actions were on card without tabbing through all of them. With this change, screenreaders can surface count information to the user (Narrator does this).

How Verified

  • local build, devtools, narrator
Microsoft Reviewers: Open in CodeFlow

@paulcam206 paulcam206 added Area-Accessibility Bugs around feature accessibility AdaptiveCards v1.2.10 labels Jun 16, 2020
@paulcam206 paulcam206 requested a review from dclaux June 16, 2020 00:08
@ghost

ghost commented Jun 16, 2020

Copy link
Copy Markdown

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@paulcam206 paulcam206 merged commit ec3564b into main Jun 16, 2020
@paulcam206 paulcam206 deleted the paulcam/actionset-aria branch June 16, 2020 00:24
@shalinijoshi19 shalinijoshi19 added AdaptiveCards v1.2.10 Platform-JavaScript Bugs or features related to the JavaScript renderer and removed AdaptiveCards v1.2.10 labels Jul 6, 2020
@ghost

ghost commented Jul 7, 2020

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Accessibility Bugs around feature accessibility Platform-JavaScript Bugs or features related to the JavaScript renderer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants